DYN-7521 : fix output value for bool type #15525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Let's make this change in the package repo though, here: https://git.autodesk.com/Dynamo/DSPythonNet3/blob/master/DSPythonNet3/DSPythonNet3Evaluator.cs#L566. |
|
Or at least also there. Not sure if we need to keep this branch around now that we have the package? |
|
Hmm I guess we can keep for a little bit longer, might help with debugging. |
BogdanZavu
added a commit
that referenced
this pull request
Oct 4, 2024
Co-authored-by: Bogdan Zavu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While we were trying to marshal the output value from python into C# we were incorrectly converting a Boolean type into an int. That was happening because the check PyInt.IsIntType also considers internally in python that Bool is a sub-type of Int.
Check these if you believe they are true
*.resxfilesReviewers
@twastvedt